jiwq commented on a change in pull request #135: SUBMARINE-321. Add JobManager and SubmitterManager components URL: https://github.com/apache/submarine/pull/135#discussion_r361897549
########## File path: submarine-server/server-api/src/main/java/org/apache/submarine/server/api/spec/JobSpec.java ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.submarine.server.api.spec; + +import java.util.Map; + +/** + * The submarine job spec for submarine job server. It consist of name, JobLibrarySpec, + * JobSubmitterSpec, the tasks. + */ +public class JobSpec { + /** + * The user-specified job name. Such as: mnist + */ + private String name; + + /** + * The user-specified ML framework spec. + */ + private JobLibrarySpec librarySpec; + + /** + * The user-specified submitter spec. + */ + private JobSubmitterSpec submitterSpec; + + /** + * The tasks of the job. + * Such as: + * TensorFlow: Chief, Ps, Worker, Evaluator + * PyTorch: Master, Worker + */ + private Map<String, JobTaskSpec> taskSpecs; Review comment: @tangzhankun The map's key is `Master` or `Worker` etc, I will add the more detailed comment for it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
