yuanzac commented on a change in pull request #135: SUBMARINE-321. Add
JobManager and SubmitterManager components
URL: https://github.com/apache/submarine/pull/135#discussion_r361893371
##########
File path:
submarine-commons/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
##########
@@ -484,7 +523,10 @@ public void updateConfiguration(String name, String
value) {
"workbench.websocket.max.text.message.size", "1024000"),
WORKBENCH_WEB_WAR("workbench.web.war",
"submarine-workbench/workbench-web/dist"),
SUBMARINE_RUNTIME_CLASS("submarine.runtime.class",
- "org.apache.submarine.server.submitter.yarn.YarnRuntimeFactory");
+ "org.apache.submarine.server.submitter.yarn.YarnRuntimeFactory"),
+ SUBMARINE_SUBMITTERS("submarine.submitters", ""),
+ SUBMARINE_SUBMITTERS_ENTRY("submarine.submitters.%s.class", ""),
Review comment:
Is it better to use
SUBMARINE_SUBMITTERS_ENTRY("submarine.submitters.%s.entry", "")
or
SUBMARINE_SUBMITTERS_CLASS("submarine.submitters.%s.class", "") ?
"entry" and "class" is not match
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
