yuanzac commented on a change in pull request #164: SUBMARINE-361. Run submarine operator in k8s URL: https://github.com/apache/submarine/pull/164#discussion_r371107030
########## File path: submarine-cloud/pkg/controller/actions.go ########## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package controller + +import ( + rapi "github.com/apache/submarine/submarine-cloud/pkg/apis/submarine/v1alpha1" + "github.com/apache/submarine/submarine-cloud/pkg/controller/clustering" + "github.com/apache/submarine/submarine-cloud/pkg/submarine" + "github.com/golang/glog" + "time" +) + +// Perform various management operations on Submarine Pod and Submarine clusters to approximate the desired state +func (c *Controller) clusterAction(admin submarine.AdminInterface, cluster *rapi.SubmarineCluster, infos *submarine.ClusterInfos) (bool, error) { + glog.Info("clusterAction()") + var err error + /* run sanity check if needed Review comment: Is it better to delete the commented lines? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
