liuxunorg commented on a change in pull request #164: SUBMARINE-361. Run
submarine operator in k8s
URL: https://github.com/apache/submarine/pull/164#discussion_r371191336
##########
File path: submarine-cloud/pkg/utils/build.go
##########
@@ -23,25 +23,30 @@ import (
// BUILDTIME should be populated by at build time: -ldflags "-w -X
github.com/apache/submarine/submarine-cloud/pkg/utils.BUILDTIME=${DATE}
// with for example DATE=$(shell date +%Y-%m-%d/%H:%M:%S ) (pay attention
not to use space!)
-var BUILDTIME string
+var BuildTime string
-// TAG should be populated by at build time: -ldflags "-w -X
github.com/apache/submarine/submarine-cloud/pkg/utils.TAG=${TAG}
-// with for example TAG=$(shell git tag|tail -1)
-var TAG string
+// TAG should be populated by at build time: -ldflags "-w -X
github.com/apache/submarine/submarine-cloud/pkg/utils.TAG=${BuildGitBranch}
+// with for example BuildGitBranch=$(git describe --all)
+var BuildGitBranch string
+
+// TAG should be populated by at build time: -ldflags "-w -X
github.com/apache/submarine/submarine-cloud/pkg/utils.TAG=${BuildGitRev}
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
