liuxunorg commented on a change in pull request #187: Add yarn submitter with
classloader.
URL: https://github.com/apache/submarine/pull/187#discussion_r381637005
##########
File path:
submarine-server/server-rpc/src/main/java/org/apache/submarine/server/rpc/SubmarineRpcServer.java
##########
@@ -109,11 +116,38 @@ private static ClientContext getClientContext(RpcContext
rpcContext) {
ClientContext clientContext = new ClientContext();
clientContext.setYarnConfig(conf);
mergeSubmarineConfiguration(clientContext.getSubmarineConfig(),
rpcContext);
+ ClassLoader classLoader = new
URLClassLoader(constructUrlsFromClasspath("../lib/submitter"));
Review comment:
The `../lib/submitter` path will store `submitter-yarn` and `submitter-k8s`
separately,
If we load all jars in the `../lib/submitter` path at the same time, there
may be conflicts.
I think the RpcServer only needs to load the jar in the `submitter-yarn` or
`submitter-k8s` path.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
