liuxunorg commented on a change in pull request #187: Add yarn submitter with
classloader.
URL: https://github.com/apache/submarine/pull/187#discussion_r381634873
##########
File path: bin/common.sh
##########
@@ -88,7 +88,7 @@ function download_mysql_jdbc_jar(){
echo "Mysql jdbc jar is downloaded and put in the path of submarine/lib."
}
-JAVA_OPTS+=" ${SUBMARINE_SERVER_JAVA_OPTS} -Dfile.encoding=UTF-8
${SUBMARINE_SERVER_MEM}"
+JAVA_OPTS+=" -Dfile.encoding=UTF-8"
Review comment:
It's because `${SUBMARINE_SERVER_JAVA_OPTS}` and `${SUBMARINE_SERVER_MEM}"`
are duplicated, so they need to be deleted, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
