On Nov 26, 2009, at 3:36 AM, Branko Čibej wrote: > Bhuvaneswaran A wrote: >> Blair brought this up earlier in this email thread [1]. Is anyone >> working on this already? If yes, please confirm. If no one confirms >> before Dec 01 2009, I will assume no one is working on it, and i'll >> start working on it. >> >> I may standardize it using PEP-8 convention, that can be validated using >> pylint interface. I will propose a pylint configuration file for >> everyone's approval, based on which we can modify all python code, >> repository wide. >> >> The same pylint configuration file may also be used with Hudson setup to >> automatically validate the code periodically and report violations, if >> any. >> > > Was the intent to actually reformat all existing code, making historic > diffs more hysteric? I understood the proposal was meant for new code, > and modifications of existing code where it wouldnt make the file look > inconsistent.
A large portion of PEP-8 doesn't have to do with formatting but Python idoms, such as using "isinstance(x, list) instead of "type(x) == list", so would be worth going through old code. Large scale reformatting probably shouldn't be done, such as switching from 2 to 4 space indentation, which would cause a diff for the whole file, so this should be avoided. Blair
