On Thu, 2009-11-26 at 07:26 -0800, Blair Zajac wrote: > > Was the intent to actually reformat all existing code, making > historic > > diffs more hysteric? I understood the proposal was meant for new > code, > > and modifications of existing code where it wouldnt make the file > look > > inconsistent. > > A large portion of PEP-8 doesn't have to do with formatting but Python > idoms, such as using "isinstance(x, list) instead of "type(x) == > list", so would be worth going through old code. > > Large scale reformatting probably shouldn't be done, such as switching > from 2 to 4 space indentation, which would cause a diff for the whole > file, so this should be avoided.
Yeah, I was hoping to making this change even for older codes. I agree to the point we shouldn't be making changes like 2 to 4 space indentation. I'll post a sample pylintrc file that can be used to report violations in existing code. If 2 space indentation is not considered as a violation, we can define pylintrc file accordingly. -- Bhuvaneswaran A CollabNet Software P Ltd. | www.collab.net
signature.asc
Description: This is a digitally signed message part
