> -----Original Message-----
> From: Philip Martin [mailto:philip.mar...@wandisco.com]
> Sent: vrijdag 15 januari 2010 10:50
> To: Paul Burba
> Cc: Bert Huijben; Mark Phippard; Hyrum K. Wright; Joe Swatosh; Subversion
> Dev
> Subject: Re: [NEW TARBALLS] Re: 1.6.8 up for signing / testing
>
> Paul Burba <ptbu...@gmail.com> writes:
>
> >> The check is inside an assert(), so it only aborts in maintainer/DEBUG
> mode.
> >>
> >> Bert
> >
> > Doh, Thanks Bert. I wasn't paying close enough attention. Indeed it
> > does assert with a debug build:
> >
> > C:\SVN\src-branch-1.6.x\Release\subversion\tests\cmdline\svn-test-
> work\repositories>svn
> > cp -mc http://localhost/svn-test-work/repositories/repo/A
> > http://localhost/svn-test-work/repositories/repo/A2 --config-dir=.
> > --username=jrandom --password=rayjandom
> > Assertion failed: svn_path_is_canonical(url, pool), file
> > ..\..\..\subversion\libsvn_subr\path.c, line 955
>
> Building -DNDEBUG makes the tests pass on Linux.
>
> So serf works "out of the box" only for a Windows release build; it
> fails for a Windows debug build, a Linux build or an OSX build
> (assuming OSX is like Linux). These other builds need to do something
> like 'configure CFLAGS=-DNDEBUG' to get serf to work.
>
> This is a regression from 1.6.6. Can we get away with mentioning this
> in the release notes? Do we need 1.6.9?
Are you sure there is a regression since 1.6.6 here?
I just performed a
$ svn diff -x -p ^/subversion/tags/1.6.6 ^/subversion/tags/1.6.8 >
1.6.6-1.6.8.patch
And I see no changes in serf at all.
If I remember correctly NDEBUG is also the default on the posix targets, except
when you enable maintainer mode?
Bert
