Matthew Bentham wrote:
> Trying to remove more uses of svn_wc_entry_t, it seems there is no way 
> at the moment to get the equivalent of entry->copied using node 
> routines.  Is this the sort of thing that is needed?
> 
> [[[
> wc-ng: work towards eliminating svn_wc_entry_t
> 
> * libsvn_wc/node.c, include/private/svn_wc_private.h
>      Add svn_wc__node_is_status_copied()
> 
> * subversion/libsvn_client/copy.c
>      (calculate_target_mergeinfo): Remove unused 'no_repos_access'

This change is logically separate from eliminating svn_wc_entry_t. Can
you submit it as a separate patch, please?

>        parameter, replace use of svn_wc__get_entry with node routines.
> 
> Patch by: Matthew Bentham <mjb67{_AT_}artvps.com>
> ]]]

[...]
> Index: subversion/libsvn_client/copy.c
> ===================================================================
> --- subversion/libsvn_client/copy.c     (revision 916192)
> +++ subversion/libsvn_client/copy.c     (working copy)
> @@ -71,20 +71,16 @@
>  /* Obtain the implied mergeinfo and the existing mergeinfo of the
>     source path, combine them and return the result in
>     *TARGET_MERGEINFO.  ADM_ACCESS may be NULL, if SRC_PATH_OR_URL is an
> -   URL.  If NO_REPOS_ACCESS is set, this function is disallowed from
> -   consulting the repository about anything.  RA_SESSION may be NULL but
> -   only if NO_REPOS_ACCESS is true.  */
> +   URL.  RA_SESSION may be NULL. */

Don't you mean, "RA_SESSION must not be NULL" ?

>  static svn_error_t *
>  calculate_target_mergeinfo(svn_ra_session_t *ra_session,

- Julian


Reply via email to