C. Michael Pilato wrote on Fri, 25 Jun 2010 at 23:14 -0000: > C. Michael Pilato wrote: > > Arfrever Frehtes Taifersar Arahesis wrote: > >> I suggest to create libsvn_ra_util library (similar to libsvn_fs_util). > >> The code of svn_ra_get_path_relative_to_root() would be moved to > >> svn_ra__get_path_relative_to_root(), which would be defined in > >> libsvn_ra_util. > >> libsvn_ra and libsvn_ra_svn would be linked against libsvn_ra_util. > >> libsvn_ra_svn would use svn_ra__get_path_relative_to_root(). > >> svn_ra_get_path_relative_to_root() would be defined in libsvn_ra and would > >> wrap svn_ra__get_path_relative_to_root(). > > > > But svn_ra_get_path_relative_to_root() and > > svn_ra_get_path_relative_to_session() call in the RA providers. So wouldn't > > that make them dependent on libsvn_ra (another dependency cycle)? > > Is there any way to make this work without just implementing these two > functions in each of the RA provider libraries, and then only calling their > library-internal implementations from inside a given provider? >
We could duplicate the prototype of svn_ra__vtable_t.get_session_url and svn_ra__vtable_t.get_repos_root, perhaps? Anyway, I see that's now fixed in trunk by r958113. Thanks! Daniel >
