On Wed, Jul 07, 2010 at 06:31:48PM +0200, Ramkumar Ramachandra wrote: > > On Wed, Jul 07, 2010 at 04:47:33PM +0200, Ramkumar Ramachandra wrote: > > Also, please don't send one patch per file, but send the entire thing > > in one patch. > > Okay. It'll probably be a small patch with just dump_editor.c.
I'm picturing something like: subversion/svnrdump/ subversion/svnrdump/svnrdump.c <-- main() program subversion/svnrdump/dump-editor.c <-- the editor plus any other support files you need in that directory. > > A set of unit tests for the new command within our regression test > > suite would be nice (similar to svnlook_tests.py and svnsync_tests.py). > > These could be submitted in a separate patch. > > Okay. Will do after the editor patch. Great. > > Unless you hear objections during the next few days, I'd suggest you > > start working on a patch aimed at our trunk (instead of at git). > > Merging it into git.git is almost effortless from here, and I'll have > the added benefit of more people looking at the code and testing > it. I'll remove it from git.git when it's merged into Subversion. Fair enough. Stefan
