[email protected] wrote on Wed, Mar 30, 2011 at 12:49:39 -0000:
>            /* ### Issue #3014: Return a specific error for broken pipes,
>             * ### with a single element in the error chain. */
> +          if (APR_STATUS_IS_EPIPE(apr_get_os_error()))
> +            return svn_error_create(SVN_ERR_IO_PIPE_WRITE_ERROR, NULL, NULL);
>            else
> +            return svn_error_wrap_apr(apr_get_os_error(), _("Write error"));
>          }
>        else
>          return svn_error_create

You evaluate errno twice.  Shouldn't you store it in a temporary variable?

Reply via email to