On Thu, Aug 4, 2011 at 12:02 PM, Mark Phippard <markp...@gmail.com> wrote: > On Thu, Aug 4, 2011 at 9:22 AM, Mark Phippard <markp...@gmail.com> wrote: >> >> On Thu, Aug 4, 2011 at 5:14 AM, Bert Huijben <b...@qqmail.nl> wrote: >>> >>> The Javahl problem caused by calling dispose() should be fixed in >>> r1153799. >>> >>> >>> >>> @Mark: Can you verify if this solves your problem? >>> >>> >>> >>> If this resolves the problem this fix might need backport to 1.6. >> >> I merged this commit and the followup to my 1.7.x branch and tested. >> This fix definitely seems to fix the crash problem. If you have not >> nominated this yet for backport to 1.7.x please do so and add my +1. >> From what I can tell, this also fixes the problem with the locks being >> left on the database. I probably need to do a little more testing on this >> to be sure, but from what I see it seems to solve the problem. Now that >> dispose works, I also have to resume my task in Subclipse of being sure to >> call it everywhere I release the object. > > Now that I have had a chance to test this on Windows, I do not think it > fixes the lock problem. The segfaults are fixed though so that is good > because we can now start calling that as we intended. > Do you have any ideas for how we can solve the lock problem? Maybe we can > add some kind of call in the dispose method that removes the locks before > doing the dispose? I will be happy to test patches.
Does r1154023 help at all? It's fairly simple, but "feels" like the right place to be destroying the wc_ctx of a client context when disposing of the SVNClient object. The tests still pass, but I didn't test this specific functionality. (Even if it doesn't improve the situation, I'd like to leave it in, since it improves the memory situation a bit.) -Hyrum -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
