I checked the subversion source code (r1182475) with cppcheck 1.51 (Windows x64
configuration). I attached the results to this email. Please have a look on the
results.
[\bindings\javahl\native\JNIThreadData.cpp:40]: (warning) Member variable
'JNIThreadData::m_formatBuffer' is not initialized in the constructor.
[\bindings\javahl\native\JNIUtil.h:40] -> [\include\svn_types.h:148]: (style)
Struct 'svn_error_t' forward declaration unnecessary, already declared
[\bindings\javahl\native\RevpropTable.cpp:46]: (performance) Possible
inefficient checking for 'm_revprops' emptiness.
[\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app' is assigned a
value that is never used
[\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable 'app' is assigned a
value that is never used
[\libsvn_client\merge.c:1466]: (style) The scope of the variable 'reason' can
be reduced
[\libsvn_delta\compat.c:341]: (style) Variable 'db' is assigned a value that is
never used
[\libsvn_delta\compat.c:351]: (style) Variable 'pb' is assigned a value that is
never used
[\libsvn_delta\compat.c:403]: (style) Variable 'fb' is assigned a value that is
never used
[\libsvn_delta\compat.c:432]: (style) Variable 'fb' is assigned a value that is
never used
[\libsvn_delta\compat.c:441]: (style) Variable 'pb' is assigned a value that is
never used
[\libsvn_delta\compat.c:859]: (style) Variable 'path' is assigned a value that
is never used
[\libsvn_delta\compose_delta.c:93] -> [\libsvn_delta\compose_delta.c:92]:
(style) Union 'alloc_block_t' hides typedef with same name
[\libsvn_delta\xdelta.c:259]: (style) Clarify calculation precedence for - and ?
[\libsvn_diff\diff.c:71]: (style) Variable 'diff' is not assigned a value
[\libsvn_diff\token.c:158]: (style) Variable 'start_position' is not assigned a
value
[\include\private\svn_temp_serializer.h:42] -> [\include\svn_string.h:120]:
(style) Struct 'svn_stringbuf_t' forward declaration unnecessary, already
declared
[\libsvn_fs_fs\rep-cache.c:189]: (error) Possible null pointer dereference: rep
- otherwise it is redundant to check if rep is null at line 195
[\libsvn_fs_fs\rep-cache.c:190]: (error) Possible null pointer dereference: rep
- otherwise it is redundant to check if rep is null at line 195
[\libsvn_fs_fs\rep-cache.c:191]: (error) Possible null pointer dereference: rep
- otherwise it is redundant to check if rep is null at line 195
[\libsvn_fs_fs\rep-cache.c:192]: (error) Possible null pointer dereference: rep
- otherwise it is redundant to check if rep is null at line 195
[\libsvn_subr\utf.c:678]: (portability) Assigning an address value to the
integer (int/long/etc) type is not portable
