Re: cppcheck results

[Philipp Kloke]

Hi,








Sent: Wednesday, October 12, 2011 8:21 PM
To: Philipp Kloke
Cc: dev@subversion.apache.org
Subject: Re: cppcheck results

On Wed, Oct 12, 2011 at 07:53:14PM +0200, Philipp Kloke wrote:

I attached some patches to this mail which fix some of the issues (the easy ones to fix). Because I am not familiar with the code of svn I am unable to work on the other issues. Furthermore I can not say, that the attached fixes will work. Please have a look on them and the remaining cppcheck results (some of them, I believe, are false positives. I removed them in the attached remaining output) -----Ursprüngliche Nachricht----- From: Stefan Sperling

I checked the subversion source code (r1182475) with cppcheck 1.51 (Windows x64 configuration). I attached the results to this email. Please have a look on the results.

Hi,

do you have time to send patches to fix some of these?

[\bindings\javahl\native\JNIThreadData.cpp:40]: (warning) Member variable
'JNIThreadData::m_formatBuffer' is not initialized in the constructor.
[\bindings\javahl\native\JNIUtil.h:40] -> [\include\svn_types.h:148]:
(style) Struct 'svn_error_t' forward declaration unnecessary, already
declared
[\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app' is assigned a
value that is never used
[\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable 'app' is assigned a
value that is never used
[\libsvn_delta\compat.c:859]: (style) Variable 'path' is assigned a value
that is never used
[\libsvn_delta\compose_delta.c:93] -> [\libsvn_delta\compose_delta.c:92]:
(style) Union 'alloc_block_t' hides typedef with same name
[\libsvn_diff\diff.c:71]: (style) Variable 'diff' is not assigned a value
[\libsvn_diff\token.c:158]: (style) Variable 'start_position' is not
assigned a value
[\include\private\svn_temp_serializer.h:42] -> [\include\svn_string.h:120]:
(style) Struct 'svn_stringbuf_t' forward declaration unnecessary, already
declared
[\libsvn_subr\utf.c:678]: (portability) Assigning an address value to the
integer (int/long/etc) type is not portable

That would be awesome. Thanks!

merge.c.patch
Description: Binary data

xdelta.c.patch
Description: Binary data

rep-cache.c.patch
Description: Binary data

Detect-nullpointers-given-to-printf-via-variable-arg.patch
Description: Binary data

RevpropTable.cpp.patch
Description: Binary data