On 18.03.2012 12:52, Daniel Shahaf wrote:
> Роман Донченко wrote on Sun, Mar 18, 2012 at 15:36:24 +0400:
>> Daniel Shahaf <danie...@elego.de> писал в своём письме Sun, 18 Mar
>> 2012 04:07:45 +0400:
>>
>>> [[[
>>> Index: subversion/bindings/swig/python/svn/fs.py
>>> ===================================================================
>>> --- subversion/bindings/swig/python/svn/fs.py       (revision 1301511)
>>> +++ subversion/bindings/swig/python/svn/fs.py       (working copy)
>>> @@ -27,6 +27,7 @@ from libsvn.fs import *
>>> from svn.core import _unprefix_names, Pool
>>> _unprefix_names(locals(), 'svn_fs_')
>>> _unprefix_names(locals(), 'SVN_FS_')
>>> +__all__ = filter(lambda x: x.lower().startswith('svn_'),
>>> locals().keys())
>>> del _unprefix_names
>>> ]]]
>>>
>>> Before:
>>>    % python -c 'from svn.fs import *;
>>>                 print [x for x in locals().keys() if "begin_txn2" in x]'
>>>    ['svn_fs_begin_txn2', 'begin_txn2']
>>>
>>> After:
>>>    % python -c 'from svn.fs import *;
>>>                 print [x for x in locals().keys() if "begin_txn2" in x]'
>>>    ['svn_fs_begin_txn2']
>>>
>> This would nullify the purpose of _unprefix_names, would it not?
>>
> No.  It enables this code:
>
>   from svn.fs import *
>   svn_fs_begin_txn2()

The only trouble with this "new way" as opposed to the "old way" is that
it's not the "Python way" :)

-- Brane

Reply via email to