Re: svn commit: r1327979 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_fs/fs-loader.c libsvn_repos/fs-wrap.c mod_dav_svn/repos.c

[Greg Stein]

On Apr 19, 2012 11:02 AM, <phi...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_fs/fs-loader.c Thu Apr 19 15:02:17
2012
>...
> +      if (kind == svn_node_dir)
> +        {
> +          svn_error_clear(err);
> +          *fs_type = apr_pstrdup(pool, SVN_FS_TYPE_BDB);
> +          return SVN_NO_ERROR;

There's no need to dup a constant string.

>...
> +      else if (!strcmp(fs_type, "bdb") && !strcmp(ap_show_mpm(),
"event"))
> +        serr = svn_error_createf(SVN_ERR_UNSUPPORTED_FEATURE, NULL,
> +                                 "BDB repository at '%s' is not
compatible "
> +                                 "with event MPM",
> +                                 fs_path);

Won't this error appear in the response? In which case, you're leaking a
server path to the client.

>...

Cheers,
-g