Philip Martin <philip.mar...@wandisco.com> writes: > I moved that code without considering that. The documentation > explicitly states that the result is allocated in pool but I think we > can change that. It also allows me to rename pool to scratch_pool. I > suppose there is a theoretical problem if libsvn_fs is dynamically > loaded and the caller is passing a pool with a longer lifetime than the > library. The constant string in the dynamic library would then have a > shorter lifetime than it does now. Unlikely in practice I think.
Oops! The other bits of the function still allocate the result so pool can't be scratch_pool. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
