On 05/08/2012 02:20 PM, Ivan Zhakov wrote: >> +/* Implements svn_close_fn_t */ >> +static svn_error_t * >> +close_handler_lazyopen(void *baton) >> +{ >> + lazyopen_baton_t *b = baton; >> + >> + SVN_ERR(lazyopen_if_unopened(b)); >> + SVN_ERR(svn_stream_close(b->real_stream)); > > I think we should just no-op in case if wrapped stream is not opened. I meant: > [[[ > if (opened) > { > SVN_ERR(svn_stream_close(b->real_stream)); > } > return SVN_NO_ERROR; > ]]]
I'm 50/50 on this change of behavior, but you clearly have an opinion, so I've changed (and documented) it. See r1335704. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Enterprise Cloud Development
signature.asc
Description: OpenPGP digital signature