I cannot build/test this right now but both patch and log message look great to me. Thanks!
On Tue, Dec 11, 2012 at 10:18:54PM +0000, Gabriela Gibson wrote: > Index: subversion/tests/cmdline/svnrdump_tests.py > =================================================================== > --- subversion/tests/cmdline/svnrdump_tests.py (revision 1420388) > +++ subversion/tests/cmdline/svnrdump_tests.py (working copy) > @@ -356,6 +356,12 @@ def copy_bad_line_endings_dump(sbox): > expected_dumpfile_name="copy-bad-line-endings.expected.dump", > bypass_prop_validation=True) > > +@XFail() > +@Issue(4263) > +def copy_bad_line_endings_load(sbox): > + "load: inconsistent line endings in svn:* props" > + run_load_test(sbox, "copy-bad-line-endings.dump") > + > def copy_bad_line_endings2_dump(sbox): > "dump: non-LF line endings in svn:* props" > run_dump_test(sbox, "copy-bad-line-endings2.dump", > @@ -771,6 +777,7 @@ test_list = [ None, > move_and_modify_in_the_same_revision_dump, > move_and_modify_in_the_same_revision_load, > copy_bad_line_endings_dump, > + copy_bad_line_endings_load, > copy_bad_line_endings2_dump, > commit_a_copy_of_root_dump, > commit_a_copy_of_root_load, > [[[ > Test for issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in > 'svn:log' property > > * subversion/tests/cmdline/svnrdump_tests.py > (copy_bad_line_endings_load): Test for '\r' line ending bug in svnrdump > (issue 4263) > ]]]
