Gabriela Gibson wrote on Wed, Dec 12, 2012 at 01:16:34 +0000: > The differences between copy-bad-line-endings.expected.dump and > copy-bad-line-endings.dump appear to be: > > 1. '\r' in the middle of a line is replaced by '\n'. > 2. '\r' at the end of a line is deleted. >
Actually what happens in (2) is that a CRLF at the end of the line becomes LF. (How to tell? Look at svn_hash_write2() for the serialisation format description, then count the bytes within the field. The second \r is byte 48 in a 49-byte field. Byte 49 is a \n.) > Let's call this "option 1". > > I had in mind to replace '\r' with '<space>'. > This would be option 2. > > Which is the prefered option? > Whatever is consistent with how we handle \r elsewhere --- eg, in svnsync, 'svnadmin dump' (which I think dumps \r literally), and 'svnrdump dump'. We might just need to reuse copy-bad-line-endings.expected.dump --- but you're correct that that is not a priori obvious. Cheers Daniel > Regards > > Gabriela >
