On Wed, Jan 9, 2013 at 7:42 PM, Branko Čibej <br...@wandisco.com> wrote:
> On 09.01.2013 19:35, Ben Reser wrote: > > On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej <br...@wandisco.com> > wrote: > >> On 09.01.2013 18:54, stef...@apache.org wrote: > >>> - if (header->is_delta) > >>> + if (header->is_delta == FALSE) > >> Can we please use logical operators to test boolean values, not > >> arithmetic ones? > Hm. I somehow got the impression from other people's code that they liked the more explicit version. Personally, I prefer the shorter one. > >> if (!header->is_delta) > > There's quite a few examples of this in the code right now that we > > should fix then > > Agreed -- we should fix them. > Ok. I'm on it right now. Being bored at the airport anyways ... -- Stefan^2. -- Certified & Supported Apache Subversion Downloads: * http://www.wandisco.com/subversion/download *
