On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: > On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling <s...@apache.org> wrote: > > How is lower-casing a multi-byte UTF-8 character going to help? > > Won't the lower-case equivalent still be a multibyte character > > and trigger the overflow check in Visual Studio? > > > Because in this case we can call apr_fnmatch without > APR_FNM_CASE_BLIND, avoid tolower calls and get case-insensitive > match.
Are we going to implement our own code to transform a string to lower case? Or do we already have such functions for UTF-8 strings? Or do you want to bypass APR and call the tolower() function provided by the operating system directly? That could result in similar issues if the current locale isn't using UTF-8. > >> And third option is to fix apr_fnmatch(). > > > > I'd very much like to do that, actually. Just have to find time. > I think the problem that svn log --search is case-insensitive only for > ASCII (latin) chars, while characters in other locales handled in > case-sensitive way. This could confuse non-English users. Yes, it can. But that's a limitation of APR, not Subversion. Once APR is fixed it will work fine.
