On Sat, Apr 20, 2013 at 8:04 PM, Ivan Zhakov <i...@visualsvn.com> wrote: > On Sat, Apr 20, 2013 at 7:54 PM, Branko Čibej <br...@wandisco.com> wrote: >> On 20.04.2013 17:42, Stefan Sperling wrote: >>> On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: >>>> On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling <s...@apache.org> wrote: >>>>> How is lower-casing a multi-byte UTF-8 character going to help? >>>>> Won't the lower-case equivalent still be a multibyte character >>>>> and trigger the overflow check in Visual Studio? >>>>> >>>> Because in this case we can call apr_fnmatch without >>>> APR_FNM_CASE_BLIND, avoid tolower calls and get case-insensitive >>>> match. >>> Are we going to implement our own code to transform a string >>> to lower case? Or do we already have such functions for UTF-8 strings? >> > No, we don't have such functions. We can try to convert UTF-8 string > to wchar_t and use towlower(), but probably it's overkill. > >> We aren't and we don't, on trunk; but the wc-collate-path branch does >> have code that can do Unicode-aware case folding through utf8proc. >> > It looks like a best solution. > I've looked to wc-collate-path branch and it seems utf8proc stuff is useful. Can we merge utf8proc to trunk?
-- Ivan Zhakov CTO | VisualSVN | http://www.visualsvn.com
