Hi,

this is merely for the record, in case someone else runs into the issue
and is looking here for a solution.

Note that SVN 1.7 is EOL and therefore isn't supported anymore. SVN
versions >= 1.8 don't suffer the problem.


The issue only applies under the following conditions:

- SVN 1.7
- SQLite 3.12.0+ (amalgamation)
- Visual Studio 2005+

In this case compiling libsvn_subr will trigger the following error:
[...]sqlite\sqlite3.c(42437): error C4013: 'rand_s' undefined; assuming
extern returning int
[[...]\1.7.22\build\win32\vcnet-vcproj\libsvn_subr.vcxproj]

The attached patch resolves the compile error (patch was suggested by
rhuijben).

Full details: http://www.luke1410.de:8090/browse/MAXSVN-55


Regards,
Stefan

--- G:\Projekte\MaxSVN\1.7.22\subversion\libsvn_subr\sqlite.c	Wed Jul 13 23:25:58 2016
+++ G:\Projekte\MaxSVN\patches\svn\1.7.22\sqlite.c	Tue Jul 12 01:22:51 2016
@@ -19,6 +19,13 @@
  *    under the License.
  * ====================================================================
  */
+#ifdef SVN_SQLITE_INLINE
+/* Include sqlite3 inline, making all symbols private. */
+  #define SQLITE_API static
+  #include <sqlite3.c>
+#else
+  #include <sqlite3.h>
+#endif
 
 #include <apr_pools.h>
 
@@ -40,14 +47,6 @@
 
 #ifdef SQLITE3_DEBUG
 #include "private/svn_debug.h"
-#endif
-
-#ifdef SVN_SQLITE_INLINE
-/* Include sqlite3 inline, making all symbols private. */
-  #define SQLITE_API static
-  #include <sqlite3.c>
-#else
-  #include <sqlite3.h>
 #endif
 
 #if !SQLITE_VERSION_AT_LEAST(3,6,18)

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to