Mark Phippard wrote:
Stefan Sperling wrote:
1. The 'decouple-shelving-cli' branch
2. The editor path fixes which don't yet work on Windows.
Since nobody has responded: Should I just make a decision by myself?
The 'decouple-shelving-cli' branch is merged and working: the
experimental shelving command line interfaces are hidden unless
explicitly enabled by the user.
I moved the API declarations from /include/ to /include/private/ as part
of that branch.
Because it is experimental, my understanding is we are free to change it
even in patch releases (and if not free in all respects, at least more
free than for stable features).
There is nothing more to do on that than an appropriate mention in the
release notes (which Nathan and Daniel have kindly been doing).
Because of that, the following part of the exchange is rather moot.
Mark Phippard wrote:
Personally, I do not care at all about experimental features and shelving. I
would favor ripping it all out and let it come back in a future release if
someone wants to finish and turn it into a feature that we are willing to
support forever. Right now, I cannot foresee a scenario where this feature
ever becomes finished. I do not see why we are even doing the work to include
it. I realize ripping it out would be work that someone has to do too
though.
I don't think asking "why are we even doing this" is helpful.
That is pretty unfair. I could go back to say nothing [...]
Anyway, I am just trying to suggest things to help us get unstuck.
Agreed. Stefan, other readers may read it differently, but I found
Mark's input here to be useful and on-topic, as well as bluntly direct.
I myself don't take any offence and am not put off by Mark's remarks, in
fact I understand and pretty much concur with his view.
If there's anything about the current state of the experimental shelving
supports that is getting in the way of a good, stable, 1.14 release, and
if we see that ripping it out (further) is a way to get past that, I
volunteer to do some or all of that ripping work.
That said, as said above I don't see that it is any longer an issue.
The editor command is part of the configuration file. We can't change the
quoting rules in a patch release [...]
The open problem is that the new quoting code won't work on Windows, [...]
OK, then let's just move past it and hope it gets fixed in APR? [...]
Agreed. We do not need to block the release until there is a full
solution including for Windows. We only need non-regression. (I
haven't looked at this issue, so I don't know if the current status is
non-regression. If so, ship it. If not, revert the recent changes.)
- Julian
