Julian Foad wrote on Wed, Jan 26, 2022 at 14:53:24 +0000: > Daniel Shahaf wrote: > > Julian Foad wrote on Fri, Jan 21, 2022 at 11:15:04 +0000: > >> Premature Hydrating > >> > >> The present implementation "hydrates" (fetches missing pristines) every > >> file within the whole subtree the operation targets. [...] > > > > Does it? Looking at textbase_walk_cb(), it only sets REFERENCED to TRUE > > for modified files. [...] > > I meant it fetches missing pristines that are deemed *wanted*, for all > files within the tree. That limits it to modified files only, but all > modified files (that don't yet have their pristines) not just those that > will be touched by the operation.
Ah, it hydrates before depth and changelist filtering? > > However, in cases such as «svn diff --diff-cmd=<GUI tool>», fetching the > > pristines (too) close to the time they are needed could result in having > > to reopen RA sessions. > > What would be a problem with that? More user-visible delays, need to authenticate again, … > How is it different from existing long-running diff scenarios? What scenarios do you have in mind? «svn diff --diff-cmd=<GUI tool> URL1 URL2»? In any case, the question isn't "Are we introducing a problem that already exists [avoidably or otherwise] in other use-cases" but "Are we introducing a problem that we can avoid introducing". Cheers, Daniel
