On Wed, Mar 23, 2022 at 5:51 PM Julian Foad <julianf...@apache.org> wrote:
> I thought maybe we would like to show this detail by default, and > suppress it when '--quiet' is passed. (Not implemented in this demo patch.) > > I was also mildly surprised to see that the fetches are not necessarily > all grouped together at the start of a high-level operation. Clearly > it's doing the 'hydrate' once per explicit target. Actually I remember > seeing this in earlier review, then forgetting as it didn't seem > important. I don't know if we care. I suppose it is unavoidable that a > client's operations might sometimes be grouped like this. Even if the > client library API allows the client to pass all targets in one call, a > client in general may choose to call the library function once per target. > > If I were the user, and particularly if I were in a use case where just > one huge file is involved, then I would also like to have feedback on > the (percentage) feedback through the file fetch. It doesn't look like > we have a good way to do that at the moment, but please correct me if > I'm wrong. > > Do we like this? Yes, and I agree --quiet should suppress. It would be good to understand the progress feedback a bit more. I have not used TortoiseSVN in a long time but I recall it hooked into our notifications to be providing an update on bytes transferred. I think they would expect that here too. I realize that is kind of separate from adding these notifications and honestly I thought those notifications for bytes transferred came from a lower level RA layer so I just assumed they would work ... maybe they still do? Mark
