Den fre 11 mars 2022 kl 12:10 skrev Vincent Lefevre <vincent-...@vinc17.net >:
> On 2022-03-11 10:29:12 +0000, Julian Foad wrote: > > Julian Foad wrote: > > > +1. Can you send a patch? > > > > By the way, the reason I ask if you would be willing, rather than "just > > quickly doing it" myself, is even a small "obvious" fix like this tends > > to require more than it initially looks like: checking if it's already > > done in head of trunk, > > This is what I'm looking at. > Hi Vincent, Did you get around to do anything about this? Even if you didn't complete it, maybe we can commit part of the job. > > > finding other similar places, > > I typically do a recursive grep to find the potential updates to be > done. > > > deciding if any of them shouldn't be updated for whatever reason, > > running the test suite, adjusting test results to match... > > Yes, this requires some time to do it well (I've already done such > kinds of changes in another project), mainly for checking. I suppose > that eveything the end user can see needs to be updated, but also > for the readers of the source code, e.g. comments like > > # See http://subversion.apache.org for more information. > > I have a question for 2 kinds of files. I think that the URLs should > be updated too in these files, but I need confirmation: > * The "CHANGES" file. > I think it is reasonable. There is also a link to subversion.tigris.org, the old-old mailinglist. The message can probably be found in lists.apache.org but it might take a bit of time to investigate exactly what message was linked originally. > * The .po files. The advantage is that this would avoid the need of > the update by the translators. A potential drawback is that the > additional character might need to adjust the formatting, e.g. to > fit on 80 columns where applicable (there aren't many concerned > lines, so that I could report any such formatting issue). > This is probably also a good idea. 80-column overflows can be reported (and potentially ignored if you don't want to get into it). Kind regards, Daniel
