On 2022-08-14 10:56:07 -0400, Nathan Hartman wrote:
> Regarding LICENSE, I also think it should remain identical.

OK (if a change is needed, perhaps Apache could do it first, like
what the FSF did for GPLv3, in 2017 IIRC). However, I think that
there would be no problems to update the license location in
source files.

> Regarding URLs that became incorrect for other reasons, e.g.,
> https://www.apache.org/dev/new-committers-guide.html#cla, I think
> those should be addressed in separate patches...
[...]
This is also what I think.

> I'm attaching an updated patch with the following changes:
> 
> (1) Revert LICENSE
> (2) Revert the license headers
> (3) In a few files [1], no URLs were changed but a newline was added
> to the end of the file, which wasn't there before. I think this should
> be done in a separate patch.
> 
> Please check the updated patch...

I'll look at it later.

> [1] Those files are:
> build/generator/templates/svn_config.vcxproj.ezt
> build/generator/templates/svn_locale.vcxproj.ezt
> build/generator/templates/vcnet_vcxproj_filters.ezt
> subversion/libsvn_subr/win32_crashrpt_dll.h

Are you sure? I cannot see any such change in my patch.
Couldn't this be the result of the revert of the licence
headers?

-- 
Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Reply via email to