Den tors 25 apr. 2024 kl 14:03 skrev Khairul Azhar Kasmiran <
kaza...@gmail.com>:
> > Any reason to keep it at this version instead of making the necessary
> changes to support Python 3?
>
> I have already made the necessary changes for Python 3 locally (and I
> just found out today that the changes are compatible with both Python
> 2 and 3 afaik), but I'm adhering to "A patch submission should contain
> one logical change; ...".
>
Great! Would you care to send that one as well?
Kind regards,
Daniel
> -- Khairul
>
> On Thu, Apr 25, 2024 at 7:51 PM Daniel Sahlberg
> <daniel.l.sahlb...@gmail.com> wrote:
> >
> > Den tors 25 apr. 2024 kl 12:30 skrev Khairul Azhar Kasmiran <
> kaza...@gmail.com>:
> >>
> >> Oops sorry I should have used a raw string. Patch reattached.
> >>
> >> [[[
> >> Make svn_apply_autoprops.py Windows-compatible.
> >>
> >> * contrib/client-side/svn_apply_autoprops.py: Add default Windows
> >> Subversion configuration path.
> >> (process_autoprop_lines): Use `ON` instead of `*` for boolean
> properties.
> >> (filter_walk): Replace `os.spawnvp()` with `subprocess.call()`.
> >> ]]]
> >>
> >> -- Khairul
> >>
> >> On Thu, Apr 25, 2024 at 6:18 PM Khairul Azhar Kasmiran
> >> <kaza...@gmail.com> wrote:
> >> >
> >> > Thanks everyone for the comments!
> >> >
> >> > > * HKEY_CURRENT_USER\Software\Tigris.org\Subversion\Config
> >> >
> >> > I think reading from this registry key should be done in a different
> >> > patch (probably not done by me) since it significantly complicates
> >> > matters.
> >> >
> >> > > To make the script compatible with Windows needs to change the
> reading configurations.
> >> >
> >> > I agree and in fact I've been using the `--config` option which is
> >> > definitely not optimal (but only needs to be done once). I've attached
> >> > an updated version of the patch that reads from
> >> > %APPDATA%\Subversion\config on Windows.
> >
> >
> > I think the new version is an improvement on the existing but I'd like
> to try it out for myself before giving a formal +1. The script is in
> contrib, so I don't think the fact that there are usecases where it DOESN'T
> work should prevent it from being improved.
> >
> > I still have one question, in an earlier e-mail you wrote that it was
> tested under Python 2.7. Any reason to keep it at this version instead of
> making the necessary changes to support Python 3? Python 3 is available on
> Microsoft Store so it is almost part of the OS.
> >
> > (I think this change and Python3 compatibility should be two separate
> commits, but I'd like to raise the question).
> >
> > Kind regards,
> > Daniel Sahlberg
> >
> >
> >>
> >> >
> >> > [[[
> >> > Make svn_apply_autoprops.py Windows-compatible.
> >> >
> >> > * contrib/client-side/svn_apply_autoprops.py: Add default Windows
> >> > Subversion configuration path.
> >> > (process_autoprop_lines): Use `ON` instead of `*` for boolean
> properties.
> >> > (filter_walk): Replace `os.spawnvp()` with `subprocess.call()`.
> >> > ]]]
> >> >
> >> > -- Khairul
> >> >
> >> > On Thu, Apr 25, 2024 at 3:06 PM Branko Čibej <br...@apache.org>
> wrote:
> >> > >
> >> > > On 25. 04. 24 00:29, Jun Omae wrote:
> >> > >
> >> > > Hi,
> >> > >
> >> > > On Tue, Apr 23, 2024 at 8:42 PM Khairul Azhar Kasmiran
> >> > > <kaza...@gmail.com> wrote:
> >> > >
> >> > > I've reattached the patch as a .txt file.
> >> > >
> >> > > On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote:
> >> > >
> >> > > Hi everyone!
> >> > >
> >> > > This is a patch to make `contrib/client-side/svn_apply_autoprops.py`
> >> > > Windows-compatible -- I have just found out that `git svn` doesn't
> >> > > honor autoprops.
> >> > >
> >> > > In POSIX environment, Subversion configurations are loaded from
> >> > > ~/.subversion/config file.
> >> > >
> >> > > 33 # The default path to the Subversion configuration file.
> >> > > 34 SVN_CONFIG_FILENAME =
> os.path.expandvars('$HOME/.subversion/config')
> >> > >
> >> > > However, the following registry or file is used in Windows.
> >> > >
> >> > > * HKEY_CURRENT_USER\Software\Tigris.org\Subversion\Config
> >> > > * %USERPROFILE%\AppData\Roaming\Subversion\config
> >> > >
> >> > >
> >> > > This is actually %APPDATA%\Subversion\config, there's no guarantee
> that %APPDATA% points to the roaming profile.
> >> > >
> >> > >
> >> > > To make the script compatible with Windows needs to change the
> reading configurations.
> >> > >
> >> > >
> >> > > Yes.
> >> > >
> >> > > -- Brane
>
