Nice, I'm almost done with my implementation and it looks like our stuff is compatible and we haven't done much duplicate work....
I didn't really do anything server side, check out my code that add a annotation layer to the d3.svg... https://github.com/apache/incubator-superset/pull/3518/files Let me know what you think. On Sat, Sep 23, 2017 at 12:38 PM, Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > Wait up! Grace and I have been working on annotations last week. > > Here's the backend part I wrote, Grace has code that shows one or many > "annotation layers" on the nvd3 time series charts > > https://github.com/apache/incubator-superset/compare/ > master...mistercrunch:annotations?expand=1 > > Those are time-related annotations, namespaced into arbitrary "layers" > stored in the backend. We have plans to support other types of annotation > like "point in place" in the future. We're open to collaborate on all that. > > I like the idea of formulas, curious how you're planning on safely > "eval-ing" the formulas too, I'm thinking users should also be able to pick > their color and style for that special series. > > Max > > On Sep 23, 2017 8:41 AM, "Fabian Menges" <fmen...@twitter.com.invalid> > wrote: > > > Hi everyone, > > > > Just wanted to give everyone heads up, I'm working on adding Annotations > > and Overlays to time series line charts in Superset. > > > > I'll probably have something done by next week. This is how it will work: > > > > There are 3 different types of annotations: > > > > 1. Events. Events are a list of dates with descriptions. They will be > > displayed as vertical lines. Their description will show up in the > > tooltips > > if you hover over them. They are fetched from a "table" slice, that > > contains the data. > > 2. Timeseries. Timeseries are are added as an additional line on the > > line chart. The name and the display properties can be configured. The > > data > > is fetched from any timeseries slce. > > 3. Formulas. Formulas are added as an additional line to the chart. > You > > will be able to enter a mathematical expression, that will be > evaluated > > on > > the client side using "mathjs". You will be able to specify display > > properties. You will be able to specify any mathematical formula e.g > > - y = 500 (horizontal line) > > - y = 0.2x (line with inclination of 0.2) > > - y = x^2 (parabola) > > > > Let me know if you have any concerns or can think of missing features. > > > > > > Fabian > > >
