ottomata commented on issue #4043: Incorrectly documented SQLALCHEMY_CUSTOM_PASSWORD_STORE URL: https://github.com/apache/incubator-superset/issues/4043#issuecomment-351741977 Yeah, I?m not using `self` at all. I only put it in there to make it work. I think a custom function shouldn?t need reference to a class instance, but should be standalone. +1 to moving it out of the Database class. :) On Thu, Dec 14, 2017 at 10:16 AM, fabianmenges <[email protected]> wrote: > Oh, I just realized this is probably because this field is on a SQLAlchemy > model and we probably have some weird interaction here. I should probably > move this function out of the Database class. > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-superset/issues/4043#issuecomment-351739677>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABjPxkJrBHGElykFSZBUVfRyKlFXdR8qks5tATvHgaJpZM4Q9_xh> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
