betodealmeida commented on a change in pull request #3996: [sql lab] deeper
support for templating
URL:
https://github.com/apache/incubator-superset/pull/3996#discussion_r157313826
##########
File path:
superset/assets/javascripts/SqlLab/components/TemplateParamsEditor.jsx
##########
@@ -0,0 +1,129 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Badge } from 'react-bootstrap';
+
+import AceEditor from 'react-ace';
+import 'brace/mode/sql';
+import 'brace/mode/json';
+import 'brace/mode/html';
+import 'brace/mode/markdown';
+import 'brace/theme/textmate';
+
+import ModalTrigger from '../../components/ModalTrigger';
+import InfoTooltipWithTrigger from '../../components/InfoTooltipWithTrigger';
+import Button from '../../components/Button';
+import { t } from '../../locales';
+
+const propTypes = {
+ onChange: PropTypes.func,
+ code: PropTypes.string,
+ language: PropTypes.oneOf(['yaml', 'json']),
+};
+
+const defaultProps = {
+ label: null,
+ description: null,
+ onChange: () => {},
+ code: '{}',
+};
+
+export default class TemplateParamsEditor extends React.Component {
+ constructor(props) {
+ super(props);
+ const codeText = props.code || '{}';
+ this.state = {
+ codeText,
+ parsedJSON: null,
+ isValid: true,
+ };
+ this.onChange = this.onChange.bind(this);
+ }
+ componentDidMount() {
+ this.onChange(this.state.codeText);
+ }
+ onChange(value) {
+ const codeText = value;
+ let isValid;
+ let parsedJSON = {};
+ try {
+ parsedJSON = JSON.parse(value);
+ isValid = true;
+ } catch (e) {
+ isValid = false;
+ }
+ this.setState({ parsedJSON, isValid, codeText });
+ if (isValid) {
+ this.props.onChange(codeText);
+ } else {
+ this.props.onChange('{}');
+ }
+ }
+ renderDoc() {
+ return (
+ <p>
+ Assign a set of parameters as <code>JSON</code> bellow
Review comment:
s/bellow/below/g
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
