betodealmeida commented on a change in pull request #3996: [sql lab] deeper
support for templating
URL:
https://github.com/apache/incubator-superset/pull/3996#discussion_r157313519
##########
File path: superset/views/core.py
##########
@@ -2161,6 +2161,8 @@ def sql_json(self):
sql = request.form.get('sql')
database_id = request.form.get('database_id')
schema = request.form.get('schema') or None
+ template_params = json.loads(
+ request.form.get('templateParams') or '{}')
Review comment:
`get` takes a default parameter:
```python
template_params = json.loads(request.form.get('templateParams', '{}'))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
