marcusianlevine commented on issue #4108: [BUGFIX]: Check datatype of results 
before converting to DataFrame
URL: 
https://github.com/apache/incubator-superset/pull/4108#issuecomment-353758145
 
 
   Ok moved the df conversion logic to helper and wrote two simple unit tests.
   
   Not sure the tests actually prevent regression because I'm mocking the query 
results...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to