marcusianlevine commented on issue #4108: [BUGFIX]: Check datatype of results before converting to DataFrame URL: https://github.com/apache/incubator-superset/pull/4108#issuecomment-353731005 @xrmx how would you recommend testing this? AFAIK the only reason for using `list(data)` instead of `np.array(data)` would be when reading certain nested column types from Hive or Presto The existing `sqllab_tests.py` has queries in it and those tests seem to be passing, but we only test against MySQL, SQLite, and Postgres from what I can tell. Any suggestions how we might simulate an embedded dict column from the test suite?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
