mistercrunch commented on a change in pull request #4134: [Geo] Added DeckGL
Arc Layer
URL:
https://github.com/apache/incubator-superset/pull/4134#discussion_r158984043
##########
File path: superset/assets/visualizations/deckgl/layers/arc.jsx
##########
@@ -0,0 +1,14 @@
+import { ArcLayer } from 'deck.gl';
+
+export default function arcLayer(formData, payload) {
+ const fd = formData;
+ const data = payload.data.arcs;
+ return new ArcLayer({
+ id: `path-layer-${fd.slice_id}`,
+ data,
+ filled: true,
+ stroked: false,
+ extruded: true,
+ pointRadiusScale: fd.point_radius_scale,
Review comment:
are these part of the ArcLayer api? Looks like the docs only reference
`strokeWdith`, here's a link to the component:
https://github.com/uber/deck.gl/blob/2f59d1a4145ba5fcc6ea5a8380813e94a083d7c5/src/core-layers/arc-layer/arc-layer.js#L32
It'd be nice to allow users to control strokeWidth too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
