mistercrunch commented on a change in pull request #4134: [Geo] Added DeckGL
Arc Layer
URL:
https://github.com/apache/incubator-superset/pull/4134#discussion_r158997368
##########
File path: superset/viz.py
##########
@@ -1824,15 +1824,16 @@ def query_obj(self):
gb = []
- spatial = fd.get('spatial')
- if spatial:
- if spatial.get('type') == 'latlong':
- gb += [spatial.get('lonCol')]
- gb += [spatial.get('latCol')]
- elif spatial.get('type') == 'delimited':
- gb += [spatial.get('lonlatCol')]
- elif spatial.get('type') == 'geohash':
- gb += [spatial.get('geohashCol')]
+ for spatial_key in ['spatial', 'start_spatial', 'end_spatial']:
Review comment:
[optional] could define a `process_spatial_control` method in the base
deckgl class, and use it in the subclasses that need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
