mistercrunch commented on issue #4114: Fix using undefined DruidMetrics for 
limit_spec
URL: 
https://github.com/apache/incubator-superset/pull/4114#issuecomment-354938005
 
 
   This method is growing a bit out of control. Not the part of the codebase 
I'm the happiest with...
   
   So is it fair to say that this bug occurs with metrics that have groupby but 
no metrics? 
   
   Now if it's a bug with Mapbox viz, it seems like `is_timeseries` should be 
`False` and we shouldn't be in the section of the code under `if 
timeseries_limit and is_timeseries:` (unless this bug occurs in another 
context?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to