mistercrunch commented on issue #4114: Fix using undefined DruidMetrics for limit_spec URL: https://github.com/apache/incubator-superset/pull/4114#issuecomment-354938005 This part of the codebase is growing a bit out of control (not your fault! it's been slipping out of control for a long time...). . Sidenote here is that the future way forward with Druid (according to Druid core committers) is with the SQL interface. For now the SQL interface vs JSON still has pros/cons and I'd assume many people are using earlier versions of Druid where JSON is the only way, so we'll have to support the JSON connector for a while. Coworker @betodealmeida at Lyft just rolled out https://github.com/betodealmeida/druid-dbapi/ which has a DBAPI driver and SQLAlchemy dialect for Druid, meaning we'll be able to use Druid through the SQLAlchemy interface. -------------- So is it fair to say that this bug occurs with metrics that have groupby but no metrics? Now if it's a bug with Mapbox viz, it seems like `is_timeseries` should be `False` and we shouldn't be in the section of the code under `if timeseries_limit and is_timeseries:` (unless this bug occurs in another context?)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
