williaster commented on a change in pull request #4226: add frontend logging functions and log loading time for Dashboard and explore view URL: https://github.com/apache/incubator-superset/pull/4226#discussion_r162573002
########## File path: superset/assets/javascripts/logger.js ########## @@ -0,0 +1,79 @@ +import $ from 'jquery'; + +export const LOG_ACTIONS_LOAD_DASHBOARD = 'load_dashboard'; +export const LOG_ACTIONS_LOAD_EXPLORE = 'load_explore'; +export const LOAD_EVENT = 'load'; Review comment: it seem strange to add `LOG_ACTIONS_` as a prefix for actions but nothing for event names. what do you think of also adding `LOG_EVENTS_` as a prefix for this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
