williaster commented on a change in pull request #4226: add frontend logging
functions and log loading time for Dashboard and explore view
URL:
https://github.com/apache/incubator-superset/pull/4226#discussion_r162571843
##########
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##########
@@ -32,18 +33,33 @@ const propTypes = {
class ExploreViewContainer extends React.Component {
constructor(props) {
super(props);
+ this.firstLoad = true;
+ this.actionLog = null;
this.state = {
height: this.getHeight(),
width: this.getWidth(),
showModal: false,
};
}
+ componentWillMount() {
+ this.actionLog = new ActionLog({
+ action: LOG_ACTIONS_LOAD_EXPLORE,
+ containerId: this.props.slice.slice_id,
Review comment:
do you think this should just be `id`? it's not exactly a container. cc
@john-bodley
also what if an explore view doesn't have a slice id/isn't saved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
