williaster commented on issue #4185: Add new visualization for custom X-Y axes URL: https://github.com/apache/incubator-superset/pull/4185#issuecomment-363272034 > Since we want to be able to display data that is not necessarily a time series or aggregated, the controls of the Table View are much more appropriate. That makes sense in general, but doesn't seem like it makes the case for a new chart type to me. It seems like matching `xy-chart` + table visualization controls could be a good update because it is more general. > To make the new "X-Y Line Chart" viz type a true 'superset' of the "Time Series - Line Chart" would require a lot of work and major refactoring. How does the 'Advance Analytics' from a "Time Series - Line Chart" work for non time series data, rolling, resampling, time shift, etc... How do Annotations work for non Time Series data? We know which columns are time columns right? It seems like we could just leverage that information to toggle on / off advanced analytics + annotations when the x-axis is time? there is precedent with showing/hiding controls in your annotations work and in the future annotations could be updated to support non-time xy-charts. while this might be considered more work, it seems like _less work_ than a future refactor of consolidating visualizations even further if we want to move to a model where we have a generic xy chart? (which again, is extremely prevalent in other plotting frameworks) perhaps I'm wrong but I really just think there's a lot of overlap here with the existing line chart and instead of bloating the # of visualizations it seems like this would just be a good generalization to make.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
