mistercrunch commented on a change in pull request #4344: Adding dashboard add
view
URL:
https://github.com/apache/incubator-superset/pull/4344#discussion_r166187322
##########
File path: superset/views/core.py
##########
@@ -507,6 +507,7 @@ class SliceAddView(SliceModelView): # noqa
list_columns = [
'id', 'slice_name', 'slice_link', 'viz_type',
'datasource_link', 'owners', 'modified', 'changed_on']
+ show_columns = SliceModelView.edit_columns + list_columns
Review comment:
This seems prone to have duplicated columns, is this not an issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
