mistercrunch commented on issue #4185: Add new visualization for custom X-Y axes URL: https://github.com/apache/incubator-superset/pull/4185#issuecomment-363314952 @williaster I was thinking that it should be different chart types as there are many controls that should become inactive when out of the time series mode. I'd say that one of the guidelines for creating new chart type as opposed to overloading an existing one is around the % of shared/relevant controls. We currently don't have support for conditional form controls, meaning that selecting certain option in one control would affect the existence of other controls or control-sections. Until we have this I think it should be 2 different chart types. I'm more troubled by the `GROUPED BY` vs `NOT GROUPED BY` options. When I added that to the Table viz early on in the project, I never thought it should be replicated to other chart types. The control panel section is bloated/confusing enough as it is without having 2 query-related sections. I think the short term solution here would be to have dropdowns with a mix of columns and metrics where we want to enable that. I think the longer term solution is to have a column-centric approach that allows (but doesn't always require) applying aggregate functions to the column. An example of that is that the `clicks` can be dragged to a `Metrics` section, and becomes `clicks [sum]` by default where an aggregation is required. You can then change it to other aggregations like `clicks [avg]` using a contextual popover. If the context doesn't require the column to be aggregated than it would allow turning off aggregations.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
