mistercrunch commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r167973124
##########
File path: superset/config.py
##########
@@ -364,6 +364,24 @@ class CeleryConfig(object):
# Interval between consecutive polls when using Hive Engine
HIVE_POLL_INTERVAL = 5
+
+# System to handle delegated data access. Implement both is_allowed_access()
and
+# is_eligible_datasource() to delegate access controls.
+class PermsDecider:
Review comment:
The interface could be such that `has_datasource_access` could return `None`
to say that it's out of its jurisdiction.
```python
def has_datasource_access(user, datasource):
if in_my_jurisdiction(datasource):
return has_access_according_to_me(user, datasource)
return None
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
