michellethomas commented on a change in pull request #4566: Adding column type
label to dropdowns
URL:
https://github.com/apache/incubator-superset/pull/4566#discussion_r173005615
##########
File path: superset/assets/javascripts/components/ColumnTypeLabel.jsx
##########
@@ -0,0 +1,34 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+const propTypes = {
+ type: PropTypes.string.isRequired,
+};
+
+export default function ColumnTypeLabel({ type }) {
+ let stringIcon;
+ let iconSize = '13';
+ if (type === '' || type === 'expression') {
+ stringIcon = '?';
+ } else if (type.match(/.*char.*/i) || type.match(/string.*/i) ||
type.match(/.*text.*/i)) {
+ stringIcon = 'ABC';
+ iconSize = '11';
+ } else if (type.match(/.*int.*/i) || type === 'LONG' || type === 'DOUBLE') {
+ stringIcon = '#';
+ } else if (type.match(/.*bool.*/i)) {
+ stringIcon = 'T/F';
+ } else if (type.match(/.*time.*/i)) {
+ stringIcon = 'time';
+ } else {
+ stringIcon = '?';
Review comment:
Yeah I agree. I added the ? because there's a specific UNKNOWN type and was
thinking maybe having ? as well as a blank could be confusing. But I agree they
should either be separate or both blank.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
