mistercrunch commented on a change in pull request #4646: Allowing limit 
ordering by post-aggregation metrics
URL: 
https://github.com/apache/incubator-superset/pull/4646#discussion_r175647879
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -1078,11 +1082,10 @@ def run_query(  # noqa / druid
         metrics_dict = {m.metric_name: m for m in self.metrics}
         columns_dict = {c.column_name: c for c in self.columns}
 
-        all_metrics, post_aggs = DruidDatasource.metrics_and_post_aggs(
+        aggregations, post_aggs = DruidDatasource.aggs_and_post_aggs(
 
 Review comment:
   `self.aggs_and_post_aggs`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to